Skip to content

Conversation

zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Jul 9, 2025

  1. add GatewayAPIInferenceExtensionVersion to the conformance report.
  2. add a consts following the style in gateway api. currently only conformance tests is using it, I'll have a following PR to follow the gateway-api pattern to generate CRD and add annotations.
  3. update the reports.md a little bit.

Example report now(the first line have the GatewayAPIInferenceExtensionVersion):

GatewayAPIInferenceExtensionVersion: v0.5.0
apiVersion: gateway.networking.k8s.io/v1
date: "2025-07-09T21:02:57Z"
gatewayAPIChannel: UNDEFINED
gatewayAPIVersion: UNDEFINED
implementation:
  contact:
  - gke-gateway-dev@google.com
  organization: GKE
  project: gke-gateway
  url: https://cloud.google.com/kubernetes-engine/docs/concepts/gateway-api
  version: TBD
kind: ConformanceReport
mode: default
profiles:
- core:
    result: success
    statistics:
      Failed: 0
      Passed: 9
      Skipped: 0
  name: Gateway
  summary: Core tests succeeded.

Copy link

netlify bot commented Jul 9, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit f43af26
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68755bd216164e00089679a2
😎 Deploy Preview https://deploy-preview-1133--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 9, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zetxqx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2025
@zetxqx
Copy link
Contributor Author

zetxqx commented Jul 9, 2025

/assign @robscott

Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zetxqx!

@zetxqx zetxqx requested a review from robscott July 9, 2025 23:16
@robscott
Copy link
Member

Thanks @zetxqx!

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2025
@robscott
Copy link
Member

Thanks @zetxqx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2025
limitations under the License.
*/

package consts
Copy link
Contributor

@nirrozenbaum nirrozenbaum Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shared offline with @zetxqx my concern about the name selection consts and it's location under pkg which may become a place where everybody put their non related consts, like a centralized place for putting all constants of the repo which I'm generally against.

we agreed to create a version/version.go at the root level to specify versioning related consts (package version).
for example like this project:
https://github.com/kubernetes/kops/blob/master/kops-version.go

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this PR, but using version.go will also allow us to define in this file CommitSHA and BuildRef vars which are currently located under /epp/pkg/metrics/metrics.go (I don't see how is it related to metrics.go).

var (
// The git hash of the latest commit in the build.
CommitSHA string
// The build ref from the _PULL_BASE_REF from cloud build trigger.
BuildRef string
)

I will push it in a follow up PR. (cc @kfswain)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! thanks @nirrozenbaum , renamed to version/version.go. Could you take another look?

cc: @robscott

Copy link
Collaborator

@kfswain kfswain Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffLuoo wrote this, I believe, to emit the commitSHA to help give context to any logs emitted (so when debugging, you can look at the specific SHA & know what the codebase looked like at that point in time). I think same with the pull base. I believe that is the fork the build is based on. Jeff to confirm however.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I placed the var in metrics.go for adding the metadata metric related to the IG https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/cmd/epp/runner/runner.go#L245. The metric tells you the build hash and version (usually tag) of the image.

Those two variables are passed in from the Dockerfile in go build here: https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/Dockerfile#L25 where the variables are passed in from:

- GIT_TAG=$_GIT_TAG
- EXTRA_TAG=$_PULL_BASE_REF
- DOCKER_BUILDX_CMD=/buildx-entrypoint
- GIT_COMMIT_SHA=$_PULL_BASE_SHA

PULL_BASE_SHA is a keyword that cloudbuild job will use to set the environment variable, check https://docs.prow.k8s.io/docs/jobs/ for environment variables. I used PULL_BASE_REF and PULL_BASE_SHA.

When you add the change, can you make sure the metric will still have the hash and build tag?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffLuoo sure!
thanks for the detailed response 👍

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2025
@nirrozenbaum
Copy link
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 72bf2d0 into kubernetes-sigs:main Jul 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants