fixed sim deployment for e2e tests #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
approved
|
@nirrozenbaum ping me offline for the emergent fix. /lgtm |
k8s-ci-robot
added
the
lgtm
EyalPazz
pushed a commit
to EyalPazz/gateway-api-inference-extension
that referenced
this pull request
Jul 9, 2025
* fixed sim deployment for e2e tests Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * rollback to v0.1.1 sim version Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * typo Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * rollback Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
BenjaminBraunDev
pushed a commit
to BenjaminBraunDev/gateway-api-inference-extension
that referenced
this pull request
Aug 12, 2025
* fixed sim deployment for e2e tests Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * rollback to v0.1.1 sim version Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * typo Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * rollback Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a new version of llm-d simulator was just released (v0.2.0).
unfortunately, this release had some breaking changes and the e2e tests are now broken.
this PR is rolling back to use a specific sim version and not latest (the one that previously worked), as we don't want our ci tests to break on simulator release in case there are breaking changes. it would be better to update the version in a controlled manner until simulator releases and apis become more stable.
I've made the necessary changes to update the sim deployment to the latest v0.2.0 release and tested it but it wasn't working for me. we would need to further explore (in a different issue) the version update.
This PR is rolling back to the latest version that working before the sim release.