-
Notifications
You must be signed in to change notification settings - Fork 180
Add unit tests for picker plugin #1103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Welcome @pabhi18! |
Hi @pabhi18. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
limitations under the License. | ||
*/ | ||
|
||
package picker_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use package picker
.
@pabhi18 this is great, thank you! I have one minor comment on the structuring - can you update the structure to align with other packages? gateway-api-inference-extension/pkg/epp/scheduling/framework/plugins/filter/filter_test.go Lines 60 to 67 in e9e4558
|
Hi @nirrozenbaum, I’ve updated the tests to follow the format you mentioned and also renamed the package to picker |
This is great! /lgtm Congrats @pabhi18 on your first inference gateway PR! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, pabhi18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you! @nirrozenbaum |
* Add unit tests for picker plugin * Fix import formatting in test * Refactor picker tests to follow table-driven format
* Add unit tests for picker plugin * Fix import formatting in test * Refactor picker tests to follow table-driven format
This PR adds unit tests for picker plugins in the scheduler framework.
Fixes #1097