Skip to content

Use Kubernetes Reader instead of full Client #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Use Kubernetes Reader instead of full Client #1093

merged 1 commit into from
Jun 30, 2025

Conversation

elevran
Copy link
Contributor

@elevran elevran commented Jun 30, 2025

Replace client.Client with client.Reader to enforce read only access to k8s API. There is no actual modification expected as part of Pod listing and updating in GIE.

@elevran
Use Kubernetes Reader instead of full Client
4366c5e 
Replace client.Client with client.Reader to enforce read only
access to k8s API. There is no actual modification expected as part of
Pod listing and updating.

Signed-off-by: Etai Lev Ran <elevran@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2025
@netlify Netlify
Copy link

netlify bot commented Jun 30, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 4366c5e
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/686291dfb7331800080a7fad
😎 Deploy Preview https://deploy-preview-1093--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @elevran. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 30, 2025
@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2025
@nirrozenbaum
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elevran, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit 42aed19 into kubernetes-sigs:main Jun 30, 2025
9 checks passed
@nirrozenbaum
Copy link
Contributor

@elevran can you push additional PR with the same changes to infpool and infmodel reconcilers for consistency?

@elevran elevran mentioned this pull request Jul 1, 2025
Merged
@elevran elevran deleted the use_k8s_reader branch July 2, 2025 12:25
EyalPazz pushed a commit to EyalPazz/gateway-api-inference-extension that referenced this pull request Jul 9, 2025
@elevran @EyalPazz
Use Kubernetes Reader instead of full Client (kubernetes-sigs#1093)
3ffb5d5 
Replace client.Client with client.Reader to enforce read only
access to k8s API. There is no actual modification expected as part of
Pod listing and updating.

Signed-off-by: Etai Lev Ran <elevran@gmail.com>
@elevran elevran mentioned this pull request Jul 24, 2025
Closed
11 tasks
BenjaminBraunDev pushed a commit to BenjaminBraunDev/gateway-api-inference-extension that referenced this pull request Aug 12, 2025
@elevran @BenjaminBraunDev
Use Kubernetes Reader instead of full Client (kubernetes-sigs#1093)
b270d56 
Replace client.Client with client.Reader to enforce read only
access to k8s API. There is no actual modification expected as part of
Pod listing and updating.

Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danehans danehans Awaiting requested review from danehans

@robscott robscott Awaiting requested review from robscott

Assignees

@nirrozenbaum nirrozenbaum

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elevran @k8s-ci-robot @nirrozenbaum