Added a helper function to get referenced plugins by type #1091
Conversation
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @shmuelk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/S
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
pkg/epp/plugins/plugins.go
Outdated
| } | ||
|
|
||
| // PluginByType retrieves the specified plugin by name and verifies its type | ||
| func PluginByType[P Plugin](handle Handle, name string) (P, error) { |
There was a problem hiding this comment.
looks good, can we pass plugins instead of handle as arg?
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
pkg/epp/plugins/plugins.go
Outdated
|
|
||
| rawPlugin := handlePlugins.Plugin(name) | ||
| if rawPlugin == nil { | ||
| return zero, fmt.Errorf("there was no plugin with the name '%s' defined", name) |
There was a problem hiding this comment.
nit1:
| return zero, fmt.Errorf("there was no plugin with the name '%s' defined", name) | |
| return zero, fmt.Errorf("there is no plugin with the name '%s' defined", name) |
pkg/epp/plugins/plugins.go
Outdated
| } | ||
| thePlugin, ok := rawPlugin.(P) | ||
| if !ok { | ||
| return zero, fmt.Errorf("the plugin with the name '%s' was not an instance of %T", name, zero) |
There was a problem hiding this comment.
nit2:
| return zero, fmt.Errorf("the plugin with the name '%s' was not an instance of %T", name, zero) | |
| return zero, fmt.Errorf("the plugin with the name '%s' is not an instance of %T", name, zero) |
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, shmuelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…-sigs#1091) * Added a helper function to get referenced plugins by type Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Added a function comment Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Update from review comment Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Updates from review comments Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
…-sigs#1091) * Added a helper function to get referenced plugins by type Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Added a function comment Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Update from review comment Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Updates from review comments Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
3 participants
This PR adds a handle function that retrieves an instantiated plugin and verifies it's type. An error is returned if either the referenced plugin doesn't exist or it is of the wrong type.