Explicitly set CGO_ENABLED=1 when running go test with race detection. #1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go race detector is implemented in C/C++ and requires CGO_ENABLED to work. However, even if CGO_ENABLED isn't explicitly set, Go assumes CGO_ENABLED=1 by default when: - C compiler (like gcc) is available - go env setup allows it (e.g., go env | grep CGO) This failed on a fresh system without a C compiler. So if (e.g.,) gcc installed, `go test -race` just quietly uses CGO under the hood. While this is not needed for local runs, the change makes CGO_ENABLED=1 explicit and portable (e.g., for containers, CI, or cross compile). Signed-off-by: Etai Lev Ran <elevran@gmail.com>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @elevran. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, elevran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
EyalPazz
pushed a commit
to EyalPazz/gateway-api-inference-extension
that referenced
this pull request
Jul 9, 2025
…kubernetes-sigs#1089) The Go race detector is implemented in C/C++ and requires CGO_ENABLED to work. However, even if CGO_ENABLED isn't explicitly set, Go assumes CGO_ENABLED=1 by default when: - C compiler (like gcc) is available - go env setup allows it (e.g., go env | grep CGO) This failed on a fresh system without a C compiler. So if (e.g.,) gcc installed, `go test -race` just quietly uses CGO under the hood. While this is not needed for local runs, the change makes CGO_ENABLED=1 explicit and portable (e.g., for containers, CI, or cross compile). Signed-off-by: Etai Lev Ran <elevran@gmail.com>
11 tasks
BenjaminBraunDev
pushed a commit
to BenjaminBraunDev/gateway-api-inference-extension
that referenced
this pull request
Aug 12, 2025
…kubernetes-sigs#1089) The Go race detector is implemented in C/C++ and requires CGO_ENABLED to work. However, even if CGO_ENABLED isn't explicitly set, Go assumes CGO_ENABLED=1 by default when: - C compiler (like gcc) is available - go env setup allows it (e.g., go env | grep CGO) This failed on a fresh system without a C compiler. So if (e.g.,) gcc installed, `go test -race` just quietly uses CGO under the hood. While this is not needed for local runs, the change makes CGO_ENABLED=1 explicit and portable (e.g., for containers, CI, or cross compile). Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go race detector is implemented in C/C++ and requires CGO to work.
However, even if CGO_ENABLED isn't explicitly set, Go assumes
CGO_ENABLED=1by default when:go envsetup allows it (e.g., see output ofgo env | grep CGO)So if (e.g.,) gcc installed,
go test -racejust quietly uses CGO under the hood. While this is not needed for local runs, the change makes CGO_ENABLED=1 explicit and portable (e.g., for containers, CI, or cross compile).Without it
make test-unitfailed on a fresh system (i.e., without a C compiler) with a somewhat cryptic message:Using
CGO_ENABLED=1is meant to make this dependency explicit.