Skip to content

Conversation

chewong
Copy link
Member

@chewong chewong commented Jun 27, 2025

This PR adds manifest validation with kubectl-validate to ensure manifests used in docs are up-to-date.

Fixes #679

Test output:

hack/verify-all.sh -v

/var/folders/90/j8qmvdf56xzd56qcj_rcfmjr0000gn/T/tmp.qsIgrSswW3/crd-all.gen.yaml...OK

/var/folders/90/j8qmvdf56xzd56qcj_rcfmjr0000gn/T/tmp.qsIgrSswW3/gateway.networking.k8s.io_gateways.yaml...OK

/var/folders/90/j8qmvdf56xzd56qcj_rcfmjr0000gn/T/tmp.qsIgrSswW3/gateway.networking.k8s.io_httproutes.yaml...OK

/var/folders/90/j8qmvdf56xzd56qcj_rcfmjr0000gn/T/tmp.qsIgrSswW3/inference.networking.x-k8s.io_inferencemodels.yaml...OK

/var/folders/90/j8qmvdf56xzd56qcj_rcfmjr0000gn/T/tmp.qsIgrSswW3/inference.networking.x-k8s.io_inferencepools.yaml...OK

/var/folders/90/j8qmvdf56xzd56qcj_rcfmjr0000gn/T/tmp.qsIgrSswW3/networking.gke.io_gcpbackendpolicies.yaml...OK

/var/folders/90/j8qmvdf56xzd56qcj_rcfmjr0000gn/T/tmp.qsIgrSswW3/networking.gke.io_healthcheckpolicies.yaml...OK

config/manifests/benchmark/benchmark.yaml...OK

config/manifests/benchmark/model-server-service.yaml...OK

config/manifests/gateway/gke/gateway.yaml...OK

config/manifests/gateway/gke/gcp-backend-policy.yaml...OK

config/manifests/gateway/gke/healthcheck.yaml...OK

config/manifests/gateway/gke/httproute.yaml...OK

config/manifests/gateway/istio/destination-rule.yaml...OK

config/manifests/gateway/istio/gateway.yaml...OK

config/manifests/gateway/istio/httproute.yaml...OK

config/manifests/gateway/kgateway/gateway.yaml...OK

config/manifests/gateway/kgateway/httproute.yaml...OK

config/manifests/inferencemodel.yaml...OK

config/manifests/inferencepool-resources.yaml...OK

config/manifests/regression-testing/inferencemodel.yaml...OK

config/manifests/regression-testing/multi-lora-regression.yaml...OK

config/manifests/regression-testing/single-workload-regression.yaml...OK

config/manifests/regression-testing/vllm/multi-lora-deployment.yaml...OK

config/manifests/vllm/cpu-deployment.yaml...OK

config/manifests/vllm/gpu-deployment.yaml...OK

config/manifests/vllm/sim-deployment.yaml...OK
SUCCESS: hack/../hack/verify-manifests.sh
Verified 209 file headers match boilerplate
SUCCESS: hack/../hack/verify-boilerplate.sh
Skipping hack/../hack/verify-all.sh

Copy link

netlify bot commented Jun 27, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 13d4101
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68796e3ff4aa87000860e640
😎 Deploy Preview https://deploy-preview-1083--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 27, 2025
@nirrozenbaum
Copy link
Contributor

cc @robscott

@kfswain
Copy link
Collaborator

kfswain commented Jul 17, 2025

Apologies for the delay @chewong. This looks great. Just one small comment. Will pass back with a LGTM when thats updated.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2025
Signed-off-by: Ernest Wong <chwong719@gmail.com>
Signed-off-by: Ernest Wong <chwong719@gmail.com>
@kfswain
Copy link
Collaborator

kfswain commented Jul 17, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4995e5d into kubernetes-sigs:main Jul 17, 2025
9 checks passed
@chewong chewong deleted the fix-679 branch July 18, 2025 16:20
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jul 31, 2025
* test: kubectl-validate manifests in presubmit

Signed-off-by: Ernest Wong <chwong719@gmail.com>

* Address PR comments

Signed-off-by: Ernest Wong <chwong719@gmail.com>

---------

Signed-off-by: Ernest Wong <chwong719@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRDs + examples should be validated with presubmits
4 participants