Skip to content

API: Refine ResolvedRefs condition for invalid ExtensionReference and expand InferencePoolReason values #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 27, 2025
Merged

API: Refine ResolvedRefs condition for invalid ExtensionReference and expand InferencePoolReason values #1070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3d37f4a
refine ExtensionReference invalid case.
zetxqx Jun 26, 2025
1781888
refine.
zetxqx Jun 26, 2025
8eced9a
extend types.
zetxqx Jun 26, 2025
afe4df2
refine InferencePoolReason
zetxqx Jun 26, 2025
5f31348
refine more.
zetxqx Jun 26, 2025
28fdc00
refine more.
zetxqx Jun 26, 2025
e2eead6
remove service and update proposals.
zetxqx Jun 27, 2025
ae77bc6
remove service and update proposals.
zetxqx Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions api/v1alpha2/inferencepool_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,11 @@ type Extension struct {
ExtensionConnection `json:",inline"`
}

// ExtensionReference is a reference to the extension deployment. When ExtensionReference is invalid,
// a 5XX status code MUST be returned for the request that would have otherwise been routed to the
// invalid backend.
// ExtensionReference is a reference to the extension.
//
// If a reference is invalid, the implementation MUST update the `ResolvedRefs`
// Condition on the InferencePool's status to `status: False`. A 5XX status code MUST be returned
// for the request that would have otherwise been routed to the invalid backend.
type ExtensionReference struct {
// Group is the group of the referent.
// The default value is "", representing the Core API group.
Expand Down Expand Up @@ -209,6 +211,7 @@ const (
// Possible reasons for this condition to be False are:
//
// * "NotSupportedByGateway"
// * "HTTPRouteNotAccepted"
//
// Possible reasons for this condition to be Unknown are:
//
Expand All @@ -227,6 +230,11 @@ const (
// InferencePool as a backend.
InferencePoolReasonNotSupportedByGateway InferencePoolReason = "NotSupportedByGateway"

// This reason is used with the "Accepted" condition when the InferencePool is
// referenced by an HTTPRoute that has been rejected by the Gateway. The user
// should inspect the status of the referring HTTPRoute for the specific reason.
InferencePoolReasonHTTPRouteNotAccepted InferencePoolReason = "HTTPRouteNotAccepted"

// This reason is used with the "Accepted" when a controller has not yet
// reconciled the InferencePool.
InferencePoolReasonPending InferencePoolReason = "Pending"
Expand All @@ -236,7 +244,7 @@ const (
// This condition indicates whether the controller was able to resolve all
// the object references for the InferencePool.
//
// Possible reasons for this condition to be true are:
// Possible reasons for this condition to be True are:
//
// * "ResolvedRefs"
//
Expand Down
6 changes: 5 additions & 1 deletion docs/proposals/002-api-proposal/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@ type Extension struct {
ExtensionConnection `json:",inline"`
}

// ExtensionReference is a reference to the extension deployment.
// ExtensionReference is a reference to the extension.
//
// If a reference is invalid, the implementation MUST update the `ResolvedRefs`
// Condition on the InferencePool's status to `status: False`. A 5XX status code MUST be returned
// for the request that would have otherwise been routed to the invalid backend.
type ExtensionReference struct {
// Group is the group of the referent.
// The default value is "", representing the Core API group.
Expand Down