Skip to content

Conversation

zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Jun 24, 2025

  1. in traffic.go: merge MakeRequestWithRequestParamAndExpectSuccess and MakeRequestAndExpectSuccess resolving Refactor conformance tests to use new test util function to replace MakeRequestAndExpectSuccess and MakeRequestAndExpectNotFound #983 .
    • MakeRequestWithRequestParamAndExpectSuccess is accepting a request type parameter which allows putting request body and request body into it. It's a superset of original MakeRequestAndExpectSuccess
  2. in helpers.go: merge GetPodsWithLabel and GetPod resolving refactor:(conformance): combine methods for getting pods in helper method. #1003
  3. also updated the HTTPRouteMultipleRulesDifferentPools to make sure it only tests the httpRoute is routing to different pods belonging different pools.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and liu-cong June 24, 2025 16:37
Copy link

netlify bot commented Jun 24, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 964a10f
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/685c2604adc90a000813d6f8
😎 Deploy Preview https://deploy-preview-1055--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zetxqx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 24, 2025
@robscott
Copy link
Member

Thanks @zetxqx!

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2025
@zetxqx zetxqx mentioned this pull request Jun 26, 2025
12 tasks
@ahg-g
Copy link
Contributor

ahg-g commented Jun 27, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 83260cc into kubernetes-sigs:main Jun 27, 2025
8 of 9 checks passed
@zetxqx
Copy link
Contributor Author

zetxqx commented Jul 2, 2025

/fixes #983

EyalPazz pushed a commit to EyalPazz/gateway-api-inference-extension that referenced this pull request Jul 9, 2025
…gs#1055)

* merge similar utility functions.

* update HTTPRouteMultipleRulesDifferentPools.

* fix util function.
@zetxqx zetxqx deleted the mergetwo branch August 11, 2025 20:16
BenjaminBraunDev pushed a commit to BenjaminBraunDev/gateway-api-inference-extension that referenced this pull request Aug 12, 2025
…gs#1055)

* merge similar utility functions.

* update HTTPRouteMultipleRulesDifferentPools.

* fix util function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants