Skip to content

refactor: rename plugin.Name() => plugin.Type() #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

refactor: rename plugin.Name() => plugin.Type() #1038

merged 1 commit into from
Jun 22, 2025

Conversation

elevran
Copy link
Contributor

@elevran elevran commented Jun 21, 2025

Following up on #1008, this replace Name() with Type() everywhere (incl. constants and fields names).

A follow up would reintroduce Name() (which can be assigned or auto-generated when unspecified 1) and then, depending on context, use Type(), Name() or both when plugin information is logged is loaded from config.

@ahg-g @kfswain @nirrozenbaum - please let me know if you prefer a single PR or two for the complete change.

Footnotes

  1. in the case of configuration, names must be provided or made consistent (e.g., default to Type()) so they can be used with well known reference name. For other cases a random generated name (<type>-xxxxx) would be used. ↩

@elevran
refactor: plugin.Name() => plugin. Type()
ceb8455 
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
@netlify Netlify
Copy link

netlify bot commented Jun 21, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit ceb8455
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6856f295ab38f40008f5f936
😎 Deploy Preview https://deploy-preview-1038--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 21, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 21, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @elevran. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elevran elevran changed the title refactor: rename plugin.Name() => plugin. Type() refactor: rename plugin.Name() => plugin.Type() Jun 21, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 21, 2025
@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 21, 2025
nirrozenbaum
nirrozenbaum reviewed Jun 21, 2025
View reviewed changes
pkg/epp/common/config/configloader_test.go
{
Name: test2Name,
PluginName: test2Name,
Name: test2Type,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about changing PluginName > Type in the configuration file and the loader?
follow up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a follow up.
Noted in PR description

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw this, we can do it in a follow up

ahg-g
ahg-g reviewed Jun 22, 2025
View reviewed changes
Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the PluginName to Type in the config api as well?

https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/api/config/v1alpha1/endpointpickerconfig_types.go#L55

@ahg-g
Copy link
Contributor

ahg-g commented Jun 22, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, elevran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5d4d3ec into kubernetes-sigs:main Jun 22, 2025
9 checks passed
shmuelk pushed a commit to shmuelk/gateway-api-inference-extension that referenced this pull request Jun 23, 2025
@elevran @shmuelk
refactor: plugin.Name() => plugin. Type() (kubernetes-sigs#1038)
ae67b79 
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
@elevran elevran deleted the plugin-type branch June 23, 2025 15:07
@nirrozenbaum nirrozenbaum mentioned this pull request Jun 23, 2025
Merged
@elevran elevran mentioned this pull request Jun 24, 2025
Merged
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 26, 2025
@elevran @rlakhtakia
refactor: plugin.Name() => plugin. Type() (kubernetes-sigs#1038)
89995f7 
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 26, 2025
@elevran @rlakhtakia
refactor: plugin.Name() => plugin. Type() (kubernetes-sigs#1038)
019ea0e 
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
EyalPazz pushed a commit to EyalPazz/gateway-api-inference-extension that referenced this pull request Jul 9, 2025
@elevran @EyalPazz
refactor: plugin.Name() => plugin. Type() (kubernetes-sigs#1038)
f4aa8b0 
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
@elevran elevran mentioned this pull request Jul 24, 2025
Closed
11 tasks
BenjaminBraunDev pushed a commit to BenjaminBraunDev/gateway-api-inference-extension that referenced this pull request Aug 12, 2025
@elevran @BenjaminBraunDev
refactor: plugin.Name() => plugin. Type() (kubernetes-sigs#1038)
ba1f0af 
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirrozenbaum nirrozenbaum nirrozenbaum left review comments

@ahg-g ahg-g ahg-g left review comments

@robscott robscott Awaiting requested review from robscott

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elevran @k8s-ci-robot @nirrozenbaum @ahg-g