Skip to content

Conversation

danehans
Copy link
Contributor

  • hack/release-quickstart.sh: Adds support for managing the image tag and pull policy for vLLM CPU and Simulator manifests. Updates the sed commands for BSD sed on MacOS (does not accept the space before the {, nor will it parse the closing brace as part of the address block).
  • .github/ISSUE_TEMPLATE/new-release.md: Updates docs

Fixes #1017

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans danehans requested a review from kfswain June 19, 2025 16:23
Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 506cdcf
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6854397b55242500089ce87a
😎 Deploy Preview https://deploy-preview-1020--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@danehans danehans requested a review from nirrozenbaum June 19, 2025 16:23
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2025
@danehans
Copy link
Contributor Author

I tested the release process with this PR:

$ make release-quickstart
./hack/release-quickstart.sh
Using release tag: v0.1.0
Using vLLM GPU image version: 0.9.1
Using vLLM CPU image version: 0.9.2
Using vLLM Simulator image version: 0.1.2
Updating pkg/README.md ...
Updating config/manifests/inferencepool-resources.yaml & config/charts/inferencepool/values.yaml ...
Updating config/manifests/vllm/gpu-deployment.yaml ...
Updating config/manifests/vllm/cpu-deployment.yaml ...
Updating config/manifests/vllm/sim-deployment.yaml ...
Staging pkg/README.md config/manifests/inferencepool-resources.yaml config/charts/inferencepool/values.yaml config/charts/body-based-routing/values.yaml config/manifests/vllm/gpu-deployment.yaml config/manifests/vllm/cpu-deployment.yaml config/manifests/vllm/sim-deployment.yaml files...
Cleaning up temporary backup files...
Release quickstart update complete.

I also confirmed the expected changes :

$ git log -u
...
--- a/config/charts/body-based-routing/values.yaml
+++ b/config/charts/body-based-routing/values.yaml
@@ -3,8 +3,8 @@ bbr:
   replicas: 1
   image:
     name: bbr
-    hub: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension
-    tag: main
+    hub: registry.k8s.io/gateway-api-inference-extension
+    tag: v0.1.0
...

@nirrozenbaum
Copy link
Contributor

@danehans what do think regarding this comment:
#1017 (comment)

@danehans danehans added this to the v0.4 milestone Jun 19, 2025
@danehans
Copy link
Contributor Author

@nirrozenbaum PTAL at my response to #1017 (comment)

@nirrozenbaum
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 17f056e into kubernetes-sigs:main Jun 19, 2025
9 checks passed
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 26, 2025
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 26, 2025
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
EyalPazz pushed a commit to EyalPazz/gateway-api-inference-extension that referenced this pull request Jul 9, 2025
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Quickstart Release Script
3 participants