-
Notifications
You must be signed in to change notification settings - Fork 179
Adds vLLM CPU and Sim Support to Release Script #1020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I tested the release process with this PR: $ make release-quickstart
./hack/release-quickstart.sh
Using release tag: v0.1.0
Using vLLM GPU image version: 0.9.1
Using vLLM CPU image version: 0.9.2
Using vLLM Simulator image version: 0.1.2
Updating pkg/README.md ...
Updating config/manifests/inferencepool-resources.yaml & config/charts/inferencepool/values.yaml ...
Updating config/manifests/vllm/gpu-deployment.yaml ...
Updating config/manifests/vllm/cpu-deployment.yaml ...
Updating config/manifests/vllm/sim-deployment.yaml ...
Staging pkg/README.md config/manifests/inferencepool-resources.yaml config/charts/inferencepool/values.yaml config/charts/body-based-routing/values.yaml config/manifests/vllm/gpu-deployment.yaml config/manifests/vllm/cpu-deployment.yaml config/manifests/vllm/sim-deployment.yaml files...
Cleaning up temporary backup files...
Release quickstart update complete. I also confirmed the expected changes : $ git log -u
...
--- a/config/charts/body-based-routing/values.yaml
+++ b/config/charts/body-based-routing/values.yaml
@@ -3,8 +3,8 @@ bbr:
replicas: 1
image:
name: bbr
- hub: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension
- tag: main
+ hub: registry.k8s.io/gateway-api-inference-extension
+ tag: v0.1.0
... |
@danehans what do think regarding this comment: |
@nirrozenbaum PTAL at my response to #1017 (comment) |
/lgtm |
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
hack/release-quickstart.sh
: Adds support for managing the image tag and pull policy for vLLM CPU and Simulator manifests. Updates the sed commands for BSDsed
on MacOS (does not accept the space before the{
, nor will it parse the closing brace as part of the address block)..github/ISSUE_TEMPLATE/new-release.md
: Updates docsFixes #1017