Consider moving internal packages into pkg?

[elevran]

The tls and runnable internal packages could be useful by other derived schedulers, such as llm-d.
If there's no hard reason to keep them private, would it be possible to make them usable outside of GIE?
Until we are able to create a fully pluggable/configurable scheduler without code changes, we require a main() in the other schedulers, setting up the EPP and that seems to have useful features in the internal/* packages.

[ahg-g]

hmm, ideally you only need to change main.go to register the out-of-tree plugins, and the reset should just work if we do our extensibility and configuration API right.

In kube-scheduler, we have a NewSchedulerCommand() call in the main function. To build the scheduler with some out of tree plugins, one only needs to add their plugins as options to that function (we call them registry options)

[elevran]

Agree - the end result we're after removing the need to duplicate GIE functionality. Right now the GIE main (which we can't reuse) imports internal packages and thus requires their duplication.
Above is the requirement. Moving internal to pkg is a solution. Having a customizable main that is only used to modify "available plugins" registration is another option and would address the requirement.
We can close this issue when the customization work can be consumed by llm-d or in favor of revised issue.
WDYT?

[ahg-g]

Sounds good, we are getting closer with #956 and the config api PR

[nirrozenbaum]

fixed by #956 and can be closed as far as I understand.

[nirrozenbaum]

/close

@elevran if you disagree please re-open

[k8s-ci-robot]

@nirrozenbaum: Closing this issue.

In response to this:

/close

@elevran if you disagree please re-open

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.