Skip to content

We should not be using corev1.ObjectReference #1149

@robscott

Description

@robscott

What happened:
InferencePool.Status.Parents.ParentRef is currently using corev1.ObjectReference:

GatewayRef corev1.ObjectReference `json:"parentRef"`

What you expected to happen:
The definition of corev1.ObjectReference strongly discourages the use of this type. We should follow that guidance and switch to a custom ObjectReference type here. To help ensure that this is largely backwards-compatible and consistent with Gateway API, we should copy the ParentGatewayReference from Gateway API.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions