envconf: use crypto/rand for random name generator #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
approved
harshanarayana
force-pushed
the
hfx/convert/random-generator-to-use-crypto
branch
from
6c19d49
to
1feb468
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, harshanarayana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently, the method used to generate random name was relying on
math/rand. Switching that tocrypto/randprovide more randomness and better behavior.Though it is not that important to use cryptographically secure randomness, it is better to do that and avoid possible collisions.
xref: https://kubernetes.slack.com/archives/C09QZ4DQB/p1720721136199309
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Added a test to account for and validate possible duplicate of random name generation.
Does this PR introduce a user-facing change?
Additional documentation e.g., Usage docs, etc.: