fixed broken exit code settings during panic recovery #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
sig/testing
k8s-ci-robot
added
approved
|
/retest |
|
/cc @vladimirvivien |
|
Thanks @harshanarayana for this simple but valuable contribution. /lgtm |
k8s-ci-robot
added
the
lgtm
vladimirvivien
approved these changes
Oct 27, 2023
| @@ -359,6 +359,9 @@ func (e *testEnv) Run(m *testing.M) int { | |||
| panic(rErr) | |||
| } | |||
| klog.Errorf("Recovering from panic and running finish actions: %s, stack: %s", rErr, string(debug.Stack())) | |||
| // Set this exit code value to non 0 to indicate that the test suite has failed | |||
There was a problem hiding this comment.
👍 Love the clear explanation here.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshanarayana, vladimirvivien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Set the valid return code after recovering from a panic under the setup handlers so that the test suite is marked as failed instead of being wrongly marked as successful.
Which issue(s) this PR fixes:
Fixes #328
Special notes for your reviewer:
NA
Does this PR introduce a user-facing change?
Additional documentation e.g., Usage docs, etc.: