Verify required checkpoint parameters are set #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
lgtm
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
Without this change it was possible to run crictl checkpoint CTR-ID without specifying '--export'. The export parameter is, however, required as it tell the CRI implementation where to store the checkpoint archive. This commit adds a check to ensure '--export' is set and not empty. Signed-off-by: Adrian Reber <areber@redhat.com>
adrianreber
force-pushed
the
2023-09-11-checkpoint-export
branch
from
200f8ad
to
04fb3af
Compare
k8s-ci-robot
removed
the
lgtm
saschagrunert
approved these changes
Sep 11, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianreber, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Without this change it was possible to run
without specifying '--export'. The export parameter is, however, required as it tell the CRI implementation where to store the checkpoint archive. This commit adds a check to ensure '--export' is set and not empty.
Which issue(s) this PR fixes:
Fixes #1235
Special notes for your reviewer:
Does this PR introduce a user-facing change?