🐛 fix(crd): Fix duplicate MinProperties/MaxProperties#1398
Open
camilamacedo86 wants to merge 1 commit into
Open
🐛 fix(crd): Fix duplicate MinProperties/MaxProperties#1398camilamacedo86 wants to merge 1 commit into
camilamacedo86 wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
camilamacedo86
force-pushed
the
fix-uplciate-validations
branch
from
3834030 to
3765c8c
Compare
k8s-ci-robot
added
size/L
camilamacedo86
commented
Apr 27, 2026
| } | ||
|
|
||
| // resolveFieldConflict handles conflicts when both src and dst have values for a field | ||
| func resolveFieldConflict(fieldName string, srcField, dstField reflect.Value, srcInt, dstInt any, errRec ErrorRecorder, srcRemVal, dstRemVal reflect.Value, fieldIndex int) bool { |
Member
Author
There was a problem hiding this comment.
The only change here is where has // remove duplicate if values are identical
The rest is == but we need to add all to its func to fix the lint issue (reduces the complexity)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a struct with
+kubebuilder:validation:MinProperties=1embeds another struct with the same setting, the CRD generates duplicates.Example:
This PR fixes this scenario and ensures that the duplication is removed.
Fixes: #1234
Assisted-by: Claude