Skip to content

✨Preserve Enum validation for IntOrString type in CRD generation#1370

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
dongjiang1989:change-IntOrString
Apr 18, 2026
Merged

✨Preserve Enum validation for IntOrString type in CRD generation#1370
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
dongjiang1989:change-IntOrString

Conversation

@dongjiang1989
Copy link
Copy Markdown
Member

@dongjiang1989 dongjiang1989 commented Mar 25, 2026 •
edited
Loading

Closes: #873

@dongjiang1989
update IntOrString generated
0503313 
Signed-off-by: dongjiang <dongjiang1989@126.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2026
@dongjiang1989 dongjiang1989 changed the title feat: Preserve Enum validation for IntOrString type in CRD generation ✨feat: Preserve Enum validation for IntOrString type in CRD generation Mar 25, 2026
@dongjiang1989
Copy link
Copy Markdown
Member Author

dongjiang1989 commented Mar 25, 2026

cc @sbueringer PTAL, thanks

@dongjiang1989 dongjiang1989 changed the title ✨feat: Preserve Enum validation for IntOrString type in CRD generation ✨feat(crd): Preserve Enum validation for IntOrString type in CRD generation Apr 2, 2026
@alvaroaleman alvaroaleman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 18, 2026
@alvaroaleman
Copy link
Copy Markdown
Member

alvaroaleman commented Apr 18, 2026

Please avoid the conventional commit prefixing, we already use the emojis for that, it just clutters the changelog.
/rettile ✨Preserve Enum validation for IntOrString type in CRD generation

@alvaroaleman
Copy link
Copy Markdown
Member

alvaroaleman commented Apr 18, 2026

/retitle ✨Preserve Enum validation for IntOrString type in CRD generation

@k8s-ci-robot k8s-ci-robot changed the title ✨feat(crd): Preserve Enum validation for IntOrString type in CRD generation ✨Preserve Enum validation for IntOrString type in CRD generation Apr 18, 2026
alvaroaleman
alvaroaleman approved these changes Apr 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, dongjiang1989

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 18, 2026

LGTM label has been added.

DetailsGit tree hash: 5787e53817707ac25034b2d1f4db8b931ec1e037

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2026
@k8s-ci-robot k8s-ci-robot merged commit 7751e1d into kubernetes-sigs:main Apr 18, 2026
7 checks passed
@dongjiang1989 dongjiang1989 deleted the change-IntOrString branch April 19, 2026 08:38
@dongjiang1989
Copy link
Copy Markdown
Member Author

dongjiang1989 commented Apr 20, 2026

Please avoid the conventional commit prefixing, we already use the emojis for that, it just clutters the changelog. /rettile ✨Preserve Enum validation for IntOrString type in CRD generation

Got it. Thanks

@dongjiang1989 dongjiang1989 mentioned this pull request Apr 21, 2026
Open
@sbueringer sbueringer mentioned this pull request Apr 29, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@chrischdi chrischdi Awaiting requested review from chrischdi

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@alvaroaleman alvaroaleman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using type intstr.IntOrString remove validation

3 participants

@dongjiang1989 @alvaroaleman @k8s-ci-robot