Skip to content

[WIP] 🌱 Refactor envtest release process to update envtest index locally - #1113

Open
sbueringer wants to merge 1 commit into
kubernetes-sigs:mainfrom
sbueringer:pr-envtest-script
Open

[WIP] 🌱 Refactor envtest release process to update envtest index locally#1113
sbueringer wants to merge 1 commit into
kubernetes-sigs:mainfrom
sbueringer:pr-envtest-script

Conversation

@sbueringer

@sbueringer sbueringer commented Dec 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

controller-tools repo is now configured in a way that blocks creation of pull requests by actions (see https://github.com/kubernetes-sigs/controller-tools/actions/runs/12463704971).
This PR changes the process. Now it's necessary to run KUBERNETES_VERSION=v1.32.0 hack/envtest/update-envtest-releases.sh and open a PR manually

/hold
for now for further discussion. Maybe there's a better way

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 27, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 27, 2024
@sbueringer

sbueringer commented Dec 27, 2024

Copy link
Copy Markdown
Member Author

/assign @vincepri @chrischdi

@sbueringer sbueringer mentioned this pull request Dec 27, 2024
Merged
camilamacedo86
camilamacedo86 approved these changes Dec 27, 2024
View reviewed changes

@camilamacedo86 camilamacedo86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2024
@camilamacedo86

camilamacedo86 commented Dec 27, 2024

Copy link
Copy Markdown
Member

/lgtm cancel

It seems OK for me, but as seen that you are looking for further options I will remove the lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2024
@k8s-ci-robot

k8s-ci-robot commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 0e77f652bb54e6234cf6aaa38815b011978fc705

@k8s-ci-robot

k8s-ci-robot commented Dec 28, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [sbueringer,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer

sbueringer commented Dec 30, 2024

Copy link
Copy Markdown
Member Author

Asked in #github-management if they can allow creating PRs with GitHub actions again: https://kubernetes.slack.com/archives/C01672LSZL0/p1735546177638379

@sbueringer

sbueringer commented Jan 7, 2025

Copy link
Copy Markdown
Member Author

Looks like we might get a fix in Q1/Q2: kubernetes/org#5126

I'll keep this PR on hold for now (we can always use the script from this PR to update the index)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2025
@k8s-ci-robot

k8s-ci-robot commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 7, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2025
@JoelSpeed

JoelSpeed commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

@sbueringer Did we ever get the ability to have actions create PRs back?

@sbueringer sbueringer changed the title 🌱 Refactor envtest release process to update envtest index locally [WIP] 🌱 Refactor envtest release process to update envtest index locally Dec 18, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2025
@sbueringer

sbueringer commented Dec 18, 2025

Copy link
Copy Markdown
Member Author

No. I keep poking but I'm not optimistic: kubernetes/org#5126 (comment)

Maybe time to merge some version of this PR and cleanly document how the promotion PR can be generated manually

@sbueringer sbueringer mentioned this pull request Dec 19, 2025
Closed
@k8s-triage-robot

k8s-triage-robot commented Jan 17, 2026

Copy link
Copy Markdown

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot

k8s-ci-robot commented Jan 17, 2026

Copy link
Copy Markdown
Contributor

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer sbueringer reopened this Jan 19, 2026
@sbueringer sbueringer removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 19, 2026
@k8s-triage-robot

k8s-triage-robot commented Apr 19, 2026

Copy link
Copy Markdown

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2026
@sbueringer
Refactor envtest release script to allow local execution
05550eb 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-triage-robot

k8s-triage-robot commented May 27, 2026

Copy link
Copy Markdown

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2026
@k8s-triage-robot

k8s-triage-robot commented Jun 26, 2026

Copy link
Copy Markdown

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@kubernetes-prow kubernetes-prow Bot closed this Jun 26, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer

sbueringer commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

/remove-lifecycle rotten
/reopen

@kubernetes-prow kubernetes-prow Bot reopened this Jun 26, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@sbueringer: Reopened this PR.

Details

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 26, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [sbueringer,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer sbueringer mentioned this pull request Jul 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi
@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86
@vincepri vincepri Awaiting requested review from vincepri

Assignees

@chrischdi chrischdi

@vincepri vincepri

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sbueringer @camilamacedo86 @k8s-ci-robot @k8s-triage-robot @JoelSpeed @vincepri @chrischdi