preserveUnknownFields=false doesn't work with crdVersions=v1

[jonnylangefeld]

crdVersions=v1 which is the new default, doesn't work in conjunction with preserveUnknownFields=false. The spec.preserveUnknownFields simply doesn't appear in the crd. There is an integration test for v1beta1, but not for v1.

I'm running the following command in a kubebuilder repo:

controller-gen "crd:preserveUnknownFields=false,crdVersions=v1" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases

I'm using defaults in my schema and if applying to a 1.16.13-gke.1 cluster, I get:

The CustomResourceDefinition "foo.example.com" is invalid: spec.preserveUnknownFields: Invalid value: true: must be false in order to use defaults in the schema

If I add spec.preserveUnknownFields manually to the crd it works

My workaround in the makefile right now is

yq w -i config/crd/bases/cluster.paas.getcruise.com_clusters.yaml spec.preserveUnknownFields false

[pugangxa]

I'm hitting the same issue, any ideas?

[npiganeau]

I had the same issue here. It was an issue about upgrading from v1beta1 to v1 CRD.
The spec.preserveUnknownFields was true in the cluster (probably because that was the default in v1beta1).
When I upgraded to v1, spec.preserveUnknownFields was not set in the manifest, but because it was in the cluster, I had the spec.preserveUnknownFields: Invalid value: true: must be false in order to use defaults in the schema error.

The solution was simply to manually add spec.preserveUnknownFields: false in the generated CRD manifest and apply it once.
From then, it worked again when applying controller-gen generated manifests (without spec.preserveUnknownFields set).

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[bhiravabhatla]

Any updates on this?