✨ stop allowing port 0 #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
Allowing port 0 doesn't provide much values when doing testing, since user will need to run some command e.g. `netstat` to figure which port is assigned. And it also make defaulting port hard. This change is not a breaking change since kubernetes-sigs@ad30658#diff-fbc18bb07cdd05391b7081acc1dfe170R81 has not been released in a stable release yet.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is reverting the change in ad30658#diff-fbc18bb07cdd05391b7081acc1dfe170R81
Allowing port 0 doesn't actually provide much values when doing testing, since user will need to run some command e.g.
netstatto figure which port is assigned. And it also make defaulting port hard.This change is not a breaking change since ad30658#diff-fbc18bb07cdd05391b7081acc1dfe170R81 has not been released in a stable release yet.
In term of testing, we could use
addr.Suggest()to get an available port and then use it in testing.