Skip to content

Comments

[release-0.23] 🐛 Fix panic when using CRs with embedded pointer structs#3436

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.23from
k8s-infra-cherrypick-robot:cherry-pick-3431-to-release-0.23
Jan 26, 2026
Merged

[release-0.23] 🐛 Fix panic when using CRs with embedded pointer structs#3436
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.23from
k8s-infra-cherrypick-robot:cherry-pick-3431-to-release-0.23

Conversation

@k8s-infra-cherrypick-robot

This is an automated cherry-pick of #3431

/assign alvaroaleman

This change bumps structured-merge-diff to pick up a fix for it panicing
when encountering objects with embedded pointer structs that are nil.

This makes us use a newer version of structured-merge-diff than
upstream, but for one release that seems okay, especially given that the
only usage is in the fake client.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2026
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2026
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: e8e73e76392bfbc562df905fe0d90898d469c38c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2026
@k8s-ci-robot k8s-ci-robot merged commit bf6bcd5 into kubernetes-sigs:release-0.23 Jan 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants