🐛 Limit depthWithPriorityMetric cardinality to 25#3419
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Jan 19, 2026
Merged
🐛 Limit depthWithPriorityMetric cardinality to 25#3419k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
approved
Member
Author
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
alvaroaleman
force-pushed
the
limit-cardinality
branch
2 times, most recently
from
daf662e to
9c026a8
Compare
sbueringer
reviewed
Jan 19, 2026
alvaroaleman
force-pushed
the
limit-cardinality
branch
from
9c026a8 to
5474f0e
Compare
Member
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
Member
|
/hold |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 66a605ebcca268398410b3376ff4db4f154f13f4 |
k8s-ci-robot
added
the
do-not-merge/hold
If a very large number of priorities is used, the cardinality of the priorityQueues `depthWithPriority` metric can grow up to the size of int, which is unreasonable high. As the functionality is useful and the above is an outlier use-case, make the metric "smart" by collecting the priorities up to a cardinality of 25 unique values and then start using a placeholder that is hopefully self-explanatory.
alvaroaleman
force-pushed
the
limit-cardinality
branch
from
5474f0e to
00b8b07
Compare
k8s-ci-robot
removed
the
lgtm
Member
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 1ec58c59ce5ddfaf53ee56f71a27aa3f0bb534ea |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a very large number of priorities is used, the cardinality of the priorityQueues
depthWithPrioritymetric can grow up to the size of int, which is unreasonable high.As the functionality is useful and the above is an outlier use-case, make the metric "smart" by collecting the priorities up to a cardinality of 25 unique values and then start using a placeholder that is hopefully self-explanatory.
Fixes #3396