✨Update golangci-lint version and modernize lint

[dongjiang1989]

1. Update golangci-lint latest version
2. Add modernize lint
3. Replace interface{} to any

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: dongjiang1989 / name: dongjiang (a0b87dc)

[k8s-ci-robot]

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alvaroaleman]

/ok-to-test

[alvaroaleman]

Why would we disable the deprecation warning?

[dongjiang1989]

Thanks @alvaroaleman
Some deprecated functions were found. I think we can fix them in the next PR.

pkg/builder/webhook.go:42:28: SA1019: admission.CustomDefaulter is deprecated: CustomDefaulter is deprecated, use Defaulter instead (staticcheck)
	customDefaulter           admission.CustomDefaulter
	                          ^
pkg/builder/webhook.go:45:28: SA1019: admission.CustomValidator is deprecated: CustomValidator is deprecated, use Validator instead (staticcheck)
	customValidator           admission.CustomValidator
	                          ^
pkg/builder/webhook.go:311:7: SA1019: admission.WithCustomValidator is deprecated: WithCustomValidator is deprecated, use WithValidator instead (staticcheck)
		w = admission.WithCustomValidator(blder.mgr.GetScheme(), blder.apiType, blder.customValidator)
		    ^
pkg/builder/webhook_test.go:1183:7: SA1019: admission.CustomDefaulter is deprecated: CustomDefaulter is deprecated, use Defaulter instead (staticcheck)
var _ admission.CustomDefaulter = &TestCustomDefaulter{}
      ^
pkg/builder/webhook_test.go:1266:7: SA1019: admission.CustomValidator is deprecated: CustomValidator is deprecated, use Validator instead (staticcheck)
var _ admission.CustomValidator = &TestCustomValidator{}
      ^
pkg/builder/webhook_test.go:1289:7: SA1019: admission.CustomDefaulter is deprecated: CustomDefaulter is deprecated, use Defaulter instead (staticcheck)
var _ admission.CustomDefaulter = &TestCustomDefaulter{}
      ^
pkg/builder/webhook_test.go:1348:7: SA1019: admission.CustomValidator is deprecated: CustomValidator is deprecated, use Validator instead (staticcheck)
var _ admission.CustomValidator = &TestCustomValidator{}
      ^
pkg/webhook/alias.go:29:24: SA1019: admission.CustomDefaulter is deprecated: CustomDefaulter is deprecated, use Defaulter instead (staticcheck)
type CustomDefaulter = admission.CustomDefaulter
                       ^
pkg/webhook/alias.go:34:24: SA1019: admission.CustomValidator is deprecated: CustomValidator is deprecated, use Validator instead (staticcheck)
type CustomValidator = admission.CustomValidator
                       ^
9 issues:
* staticcheck: 9

[sbueringer]

Let's use local nolint comments for these cases. We just deprecated CustomDefaulter/CustomValidator we cannot remove them that quickly

[dongjiang1989]

Let's use local nolint comments for these cases. We just deprecated CustomDefaulter/CustomValidator we cannot remove them that quickly

Thanks @sbueringer
Got it

[alvaroaleman]

Please remove this, we do not want to globally disable deprecation checks. Please add local nolint comments as needed instead, like Stefan suggested

[dongjiang1989]

Thanks @alvaroaleman @sbueringer
Fixed. Done

[dongjiang1989]

/test pull-controller-runtime-test

[dongjiang1989]

@alvaroaleman Please re-check it, thanks

[dongjiang1989]

/test pull-controller-runtime-test

[alvaroaleman]

Thanks!

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 7bc2b3fba10600f0428181b99a759cc40a44690a

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, dongjiang1989

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment