🌱chore: Change sort to slices package#3370
Conversation
|
Hi @dongjiang1989. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sort to slices packagesort to slices package
|
LGTM label has been added. DetailsGit tree hash: 420a60e1118ea17867ad152a24557d00ae987584 |
|
/ok-to-test |
|
/hold |
8481c33 to
d2ccfbe
Compare
|
@sbueringer @alvaroaleman fixed. Please re-check it |
Signed-off-by: dongjiang <dongjiang1989@126.com>
19f3156 to
2dcd791
Compare
|
Thx! /lgtm Leaving hold so @alvaroaleman can take another look |
|
LGTM label has been added. DetailsGit tree hash: 209d12163f728d28fb1ba1cd0ddde0c6113eecf7 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, dongjiang1989 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Replace the sort package with the slices package to simplify the code.