⚠️ Default selectors to Nothing if it is nil for MatchingLabelsSelector and MatchingFieldsSelector#3279
Conversation
…or and MatchingFieldsSelector
|
Hi @acumino. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @sbueringer |
|
/ok-to-test |
MatchingLabelsSelector and MatchingFieldsSelectorMatchingLabelsSelector and MatchingFieldsSelector
MatchingLabelsSelector and MatchingFieldsSelectorMatchingLabelsSelector and MatchingFieldsSelector
|
LGTM label has been added. DetailsGit tree hash: 16a47334870891aed9482e6966ba44660880fdb8 |
|
/hold in case @sbueringer wants to check |
|
Thx! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acumino, alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If the selector is not set for
MatchingLabelsSelectorandMatchingFieldsSelector, then the list call panics.This PR updates
MatchingLabelsSelectorandMatchingFieldsSelectorto default their Selector fields to labels.Nothing() and fields.Nothing() respectively if unset in ApplyToList.