🌱examples-builtin: Refactor controller setup to use builder pattern#3265
🌱examples-builtin: Refactor controller setup to use builder pattern#3265k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: suzi1037 <xiaoxin09@hotmail.com>
|
Welcome @s-z-z! |
|
Hi @s-z-z. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I test it, and it works correctly. here is the result command line operationthe rs got the label controller log |
…By and move logging to ctrl.SetLogger Signed-off-by: suzi1037 <xiaoxin09@hotmail.com>
|
LGTM label has been added. DetailsGit tree hash: d9614a9e1e60311c58ac2c07f5691c33c0914e5e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, s-z-z The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What
Refactors builtin example:
main.goto usecontroller-runtimebuilder pattern (ctrl.NewControllerManagedBy) instead ofcontroller.Newfor controller setup, consolidating ReplicaSet and Pod watches.Why
The builder pattern is the recommended approach for Kubernetes controllers, improving code readability, maintainability, and alignment with community practices.
Impact
No functional changes. Enhances code clarity and consistency with other projects.