✨Add RELEASE_TAG to tools/setup-envtest to show binary version with setup-envtest version

[troy0820]

With the setup-envtest binary, it is difficult to determine the version of the binary that is installed. This will allow the user to use the command setup-envtest version to see what version of the binary is installed.

Note: This is targeting the branch when built and not a specific tag. The setup-envtest instructions for installation shows to target the release branch for specific versions

This will target the release tag defined in the GitHub action when binaries are built.

Resolves #3158

[sbueringer]

I think setup-envtest should show the exact version. We are also publishing setup-envtest binaries on every release and it's not ideal if that just shows the branch

(there was some similar work in controller-gen recently: kubernetes-sigs/controller-tools#1046. In general I would expect setup-envtest and controller-gen to behave the same)

[troy0820]

I think setup-envtest should show the exact version. We are also publishing setup-envtest binaries on every release and it's not ideal if that just shows the branch

(there was some similar work in controller-gen recently: kubernetes-sigs/controller-tools#1046. In general I would expect setup-envtest and controller-gen to behave the same)

This makes sense. I made the assumption with how we install to provide the same installation version technique. I can change this to provide the same as controller-gen.

[sbueringer]

Thx!

I'll cherry-pick so we can verify this e2e with the next patch release

/cherry-pick release-0.20

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

Details

In response to this:

Thx!

I'll cherry-pick so we can verify this e2e with the next patch release

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: cc081df330d194cd9bc15b0206524629dec178d5

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, troy0820

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #3175

Details

In response to this:

Thx!

I'll cherry-pick so we can verify this e2e with the next patch release

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[troy0820]

Suggested change

	// -ldflags "-X sigs.k8s.io/controller-tools/pkg/version.version=v1.0.0"
	// -ldflags "-X sigs.k8s.io/controller-runtime/tools/setup-envtest/version.version=v1.0.0"

[troy0820]

@sbueringer I can make a PR for this to fix the godoc rendering with the correct comment.

[sbueringer]

Ups. Yup, thx!