🐛 Fix race in logger test#3150
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Mar 8, 2025
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
sbueringer
commented
Mar 8, 2025
| Expect(messages).To(ContainElement( | ||
| ContainSubstring(msg), | ||
| )) | ||
| Eventually(func(g Gomega) { |
Member
Author
There was a problem hiding this comment.
As we had a race condition here I assume it's also necessary to use Eventually
sbueringer
force-pushed
the
pr-fix-test-race
branch
from
fa86d3f to
a7b9393
Compare
Member
Author
|
/assign @alvaroaleman |
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-fix-test-race
branch
from
a7b9393 to
6f0283f
Compare
alvaroaleman
approved these changes
Mar 8, 2025
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: d338113c48b59b34e17b7648bc7ed576009cff1b |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
Saw tests failing a few times with race condition: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_controller-runtime/3138/pull-controller-runtime-test/1898308642759774208