🐛 Create BinaryAssetsDirectory if it doesn't exist#3137
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Mar 4, 2025
Merged
🐛 Create BinaryAssetsDirectory if it doesn't exist#3137k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
10 tasks
k8s-ci-robot
added
the
size/XS
Member
Author
|
/assign @alvaroaleman @vincepri /hold |
k8s-ci-robot
added
the
do-not-merge/hold
Contributor
|
/lgtm Issue and fix seem to make sense to me |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: bf023d66e27fafe9cb32d8265aa4745cb88e082c |
Member
|
Adding an /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Member
|
/lgtm |
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 13, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 13, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 14, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 14, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 17, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 19, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
This was referenced May 23, 2025
This was referenced May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
Fixes #2810 (comment)