Skip to content

Comments

🐛 fix: cache should list out of global cache when present and necessary#3126

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
joelanford:fix-multinamespace-cache-list
Feb 20, 2025
Merged

🐛 fix: cache should list out of global cache when present and necessary#3126
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
joelanford:fix-multinamespace-cache-list

Conversation

@joelanford
Copy link
Member

@joelanford joelanford commented Feb 20, 2025

When the cache options are configured with DefaultNamespaces which include an entry with cache.AllNamespaces, listing from the cache should fallback to the global cache if there are no namespace-specific caches that match the namespace from the list options.

@joelanford
fix: cache should list out of global cache when present and necessary
bfa6d9c 
When the cache options are configured with DefaultNamespaces which
include an entry with `cache.AllNamespaces`, listing from the cache
should fallback to the global cache if there are no namespace-specific
caches that match the namespace from the list options.

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2025
@troy0820
Copy link
Member

troy0820 commented Feb 20, 2025

/lgtm
/hold

In case anyone else wants to review.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 20, 2025

LGTM label has been added.

DetailsGit tree hash: c1454f1f125977c106cc0c59b523176be5914316

alvaroaleman
alvaroaleman approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a subtle one, thanks for the fix!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alvaroaleman
Copy link
Member

alvaroaleman commented Feb 20, 2025

/hold cancel
/cherrypick release-0.20
/cherrypick release-0.19

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2025
@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Feb 20, 2025

@alvaroaleman: once the present PR merges, I will cherry-pick it on top of release-0.19, release-0.20 in new PRs and assign them to you.

Details

In response to this:

/hold cancel
/cherrypick release-0.20
/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 9024933 into kubernetes-sigs:main Feb 20, 2025
11 of 12 checks passed
@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Feb 20, 2025

@alvaroaleman: new pull request created: #3127

Details

In response to this:

/hold cancel
/cherrypick release-0.20
/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 20, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Feb 20, 2025

@alvaroaleman: new pull request created: #3128

Details

In response to this:

/hold cancel
/cherrypick release-0.20
/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 20, 2025
Merged
@sbueringer
Copy link
Member

sbueringer commented Feb 24, 2025

/lgtm

MitchLewis930 added a commit to Signal65/controller-runtime-Greptile that referenced this pull request Jan 21, 2026
@MitchLewis930
Revert "Merge pull request kubernetes-sigs#3126 from joelanford/fix-m…
add762f 
…ultinamespace-cache-list"

This reverts commit 9024933, reversing
changes made to 6f61111.
@greptile-apps greptile-apps bot mentioned this pull request Jan 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@FillZpp FillZpp Awaiting requested review from FillZpp

Assignees

@troy0820 troy0820

@alvaroaleman alvaroaleman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joelanford @troy0820 @k8s-ci-robot @alvaroaleman @k8s-infra-cherrypick-robot @sbueringer