⚠ Bump to k8s.io/* v0.33.0-alpha.1#3104
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
|
||
| Eventually(func() *corev1.Event { | ||
| evts, err := clientset.CoreV1().Events("").Search(m.GetScheme(), &ns) | ||
| evts, err := clientset.CoreV1().Events("").SearchWithContext(ctx, m.GetScheme(), &ns) |
There was a problem hiding this comment.
fyi. This was not a breaking change in client-go. Search is just deprecated in favor of SearchWithContext
| @@ -109,6 +110,10 @@ func (f *FakeInformer) Run(<-chan struct{}) { | |||
| f.RunCount++ | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The SharedIndexInformer interface has new additional methods. So I extended the FakeInformer accordingly.
This was expected and previously discussed in kubernetes/kubernetes#126387 (comment)
There was a problem hiding this comment.
In general there should be some follow-up to leverage changes like kubernetes/kubernetes#127709 & kubernetes/kubernetes#126387
There was a problem hiding this comment.
You can use the "trick" from kubernetes/kubernetes#126379 with 's;// *Contextual logging: ;//logcheck:context //;' in your vendor directory, then run logcheck to get errors about using functions which have better alternatives.
We haven't sketched out a timeline yet, but for 1.33 I am hoping to adapt source code. Then in 1.34, those free-form comments could become proper logcheck:context tags and thus active for users of logcheck.
There was a problem hiding this comment.
For reference. Replacing // Contextual Logging: with // Deprecated: also works (and doesn't require the logcheck linter)
sbueringer
changed the title
|
/assign @alvaroaleman @vincepri (cc @pohly just fyi, I think everything as expected so far) |
alvaroaleman
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 130eabcc979cf864fe69f6cb18e5aa9608e9c547 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
* Bump to k8s.io/* v0.33.0-alpha.1 Signed-off-by: Stefan Büringer buringerst@vmware.com * Implement new SharedIndexInformer methods in FakeInformer * use SearchWithContext instead of deprecated Search --------- Signed-off-by: Stefan Büringer buringerst@vmware.com
5 participants
Signed-off-by: Stefan Büringer buringerst@vmware.com