Skip to content

Comments

[release-0.19] 🐛fix(controller): support WaitForSync in custom TypedSyncingSource#3087

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:release-0.19from
tareksha:typed_waitforsync
Jan 23, 2025
Merged

[release-0.19] 🐛fix(controller): support WaitForSync in custom TypedSyncingSource#3087
k8s-ci-robot merged 2 commits intokubernetes-sigs:release-0.19from
tareksha:typed_waitforsync

Conversation

@tareksha
Copy link
Contributor

@tareksha tareksha commented Jan 23, 2025

this is a cherry pick of #3084

@tareksha
🐛fix(controller): support WaitForSync in custom TypedSyncingSource (k…
8017666 
…ubernetes-sigs#3084)

* 🐛fix(controller): use generic WaitForSync

There is already support for defining `TypedSyncingSource` but the original code still checks for the original `SyncingSource` before callign `WaitForSync(ctx)` which does not work for custom typed controller.

this fix should be backported to v0.19

* test
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 23, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 23, 2025

Hi @tareksha. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 23, 2025
@tareksha tareksha mentioned this pull request Jan 23, 2025
Merged
@sbueringer sbueringer changed the title 🐛fix(controller): support WaitForSync in custom TypedSyncingSource (#… [release-0.19] 🐛fix(controller): support WaitForSync in custom TypedSyncingSource (#… Jan 23, 2025
@sbueringer sbueringer changed the title [release-0.19] 🐛fix(controller): support WaitForSync in custom TypedSyncingSource (#… [release-0.19] 🐛fix(controller): support WaitForSync in custom TypedSyncingSource Jan 23, 2025
@sbueringer
Copy link
Member

sbueringer commented Jan 23, 2025

Thx!

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 23, 2025

LGTM label has been added.

DetailsGit tree hash: 3d50a4d61465390b27bde2b864c4cef7e7db4baa

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, tareksha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit e022b91 into kubernetes-sigs:release-0.19 Jan 23, 2025
13 checks passed
@tareksha tareksha deleted the typed_waitforsync branch January 23, 2025 14:55
@tareksha
Copy link
Contributor Author

tareksha commented Jan 23, 2025

hi @sbueringer when is a new patch release of v0.19 expected?

@sbueringer
Copy link
Member

sbueringer commented Jan 23, 2025

@tareksha Now

@renovate renovate bot mentioned this pull request Feb 12, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inteon inteon Awaiting requested review from inteon

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tareksha @k8s-ci-robot @sbueringer