Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 Bump k8s.io/* deps to v0.31.0-alpha.3 #2872

Merged
merged 1 commit into from
Jul 9, 2024
Merged

🏃 Bump k8s.io/* deps to v0.31.0-alpha.3 #2872

merged 1 commit into from
Jul 9, 2024

Conversation

twz123
Copy link
Contributor

@twz123 twz123 commented Jul 3, 2024

Adapt to upstream changes:

@twz123
🏃 Bump k8s.io/* deps to v0.31.0-alpha.3
b068c2c 
Adapt to upstream changes:

* 5e6a4937f5a KEP-4633: Allow health-only anonymous auth mode.

Wrap the anonymous flag in a struct pointer.

* 75d6f024326 Add field tracker support to client fake fixtures

Add CreateOptions and UpdateOptions to the existing versionedTracker
methods, and also add the Patch method that was introduced upstream.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @twz123. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2024
@twz123 twz123 marked this pull request as ready for review July 3, 2024 13:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from inteon July 3, 2024 13:22
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2024
@sbueringer
Copy link
Member

sbueringer commented Jul 3, 2024 •
edited
Loading

@twz123 Can you please split up the changes in separate PRs if possible? I assume the follow-up to this change kubernetes/kubernetes#125560 can be done in a separate PR?

@twz123
Copy link
Contributor Author

twz123 commented Jul 3, 2024

I assume the follow-up to this change kubernetes/kubernetes#125560 can be done in a separate PR?

The addition of the variadic options arguments is necessary to make it compile, and the addition of the Patch method is necessary to pass the fake client unit tests, as k8s.io/client-go/testing.ObjectReaction changed the way it reacts to Patch actions. I can split up the fixes for the tests into a separate PR, if you prefer.

@sbueringer
Copy link
Member

Ah thx for the context. No I think then let's keep everything in this one PR

@sbueringer
Copy link
Member

/assign
/assign @alvaroaleman

alvaroaleman
alvaroaleman reviewed Jul 7, 2024
View reviewed changes
pkg/client/fake/client.go
if err != nil {
return err
}
if obj == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these nilchecks? This should never happen and if it does, there is a bug somewhere

Copy link
Contributor Author

@twz123 twz123 Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updateObject can return nil, nil currently, if an object is created (line 430) or deleted (line 491). In that case, the object tracker's Update/Patch methods shouldn't be called.

alvaroaleman
alvaroaleman approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f85a8f1e9027ca4197c7257fa7f8d9c7eeab573c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, twz123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7b496e6 into kubernetes-sigs:main Jul 9, 2024
9 checks passed
@twz123 twz123 deleted the bump-k8s-1.31 branch July 9, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@FillZpp FillZpp Awaiting requested review from FillZpp

@sbueringer sbueringer Awaiting requested review from sbueringer

@inteon inteon Awaiting requested review from inteon

Assignees

@sbueringer sbueringer

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twz123 @k8s-ci-robot @sbueringer @alvaroaleman