Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.18] 🐛 Cache: Fix label defaulting of byObject when namespaces are configured #2808

Commits on May 1, 2024

  1. bug: Cache: Fix label defaulting of byObject when namespaces are conf…

    …igured
    
    Currently, if there are global namespaces configured and no per-object
    namesapces, while there is both a global and a per-object labelSelector,
    we will:
    1. Default the namespaces labelSelector from `DefaultLabelSelector`
    2. Copy the namespaces including config into `byObject.Namespaces`
    
    And thus end up with the global labelSelector overriding the per-object
    one, this change fixes that by swapping step 1 and 2.
    alvaroaleman authored and k8s-infra-cherrypick-robot committed May 1, 2024
    Configuration menu
    Copy the full SHA
    87cae4c View commit details
    Browse the repository at this point in the history