⚠️ Use limited reader in webhooks #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/L
|
@inteon would you mind splitting this up in one PR per change, so discussions can stay targeted and the changelog will have a more meaningful entry than "Improve Webhook"? |
inteon
changed the title
inteon
force-pushed
the
improve_webhooks
branch
from
7206b34
to
a169f8b
Compare
Ok, this PR now focuses on adding |
inteon
force-pushed
the
improve_webhooks
branch
from
a169f8b
to
03eca92
Compare
k8s-ci-robot
added
size/M
alvaroaleman
reviewed
Dec 3, 2023
inteon
force-pushed
the
improve_webhooks
branch
from
03eca92
to
016ba4c
Compare
inteon
force-pushed
the
improve_webhooks
branch
2 times, most recently
from
b96f9fa
to
9dcfc53
Compare
sbueringer
reviewed
Dec 18, 2023
inteon
force-pushed
the
improve_webhooks
branch
from
d703a85
to
dc57d59
Compare
|
/retest |
|
@inteon PTAL when you have some time :) |
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
improve_webhooks
branch
from
dc57d59
to
a1a68d0
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
improve_webhooks
branch
from
a1a68d0
to
930ab18
Compare
|
@sbueringer I updated the limits and comments based on the review feedback. |
sbueringer
added
the
tide/merge-method-squash
|
Thx! /lgtm /assign @alvaroaleman @vincepri |
k8s-ci-robot
added
the
lgtm
alvaroaleman
reviewed
Jan 8, 2024
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
k8s-ci-robot
removed
the
lgtm
inteon
changed the title
alvaroaleman
approved these changes
Jan 8, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a LimitedReader which prevents DOS attacks due to OOM caused by the
io.ReadAllfunction.Depends on #2604.
Code is based on https://github.com/kubernetes/kubernetes/blob/c28c2009181fcc44c5f6b47e10e62dacf53e4da0/staging/src/k8s.io/pod-security-admission/cmd/webhook/server/server.go