🌱 Use runtime.Unstructured interface instead of Unstructured struct#2168
Conversation
Signed-off-by: Vince Prignano <vincepri@redhat.com>
|
/assign @alvaroaleman @sbueringer |
I'm in favor of this. The code looks more clear and we don't have to check both Unstructured and UnstructuredList in some of the places. |
alvaroaleman
left a comment
There was a problem hiding this comment.
Looks like a clear simplification to me and doesn't result in any public api changes or test changes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vince Prignano vincepri@redhat.com
Fixes #415
I'm indifferent if we actually want to do this or not, if we decide not to, we should also close the related issue as well