Skip to content

The reflector metrics is empty. #817

Closed
@qibobo

Description

@qibobo

In client_go_adapter.go, restclient and reflector metrics are registered as the following:

func init() {
	registerClientMetrics()
	registerReflectorMetrics()
}

When I import this go package, there are restclient metrics, but there is no reflector metric.
I have checked the client-go repo and found seem no one calls metricsFactory.

My question is that does reflector enable by default or it need some extra steps to enble?

https://github.com/kubernetes/client-go/blob/f772958f8a2941ad60a4bf5fb13da0acee7b2d76/tools/cache/reflector_metrics.go#L77-L89

var metricsFactory = struct {
	metricsProvider MetricsProvider
	setProviders    sync.Once
}{
	metricsProvider: noopMetricsProvider{},
}

// SetReflectorMetricsProvider sets the metrics provider
func SetReflectorMetricsProvider(metricsProvider MetricsProvider) {
	metricsFactory.setProviders.Do(func() {
		metricsFactory.metricsProvider = metricsProvider
	})
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.priority/awaiting-more-evidenceLowest priority. Possibly useful, but not yet enough support to actually get it done.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions