setup-envtest selecting older versions

[cbandy]

When two versions are available, setup-envtest use picks the older version rather than the newer one:

$ go run sigs.k8s.io/controller-runtime/tools/setup-envtest@latest use --print=overview 1.34.0
Version: 1.34.0
OS/Arch: linux/arm64

$ go run sigs.k8s.io/controller-runtime/tools/setup-envtest@latest use --print=overview 1.34.1
Version: 1.34.1
OS/Arch: linux/arm64

$ go run sigs.k8s.io/controller-runtime/tools/setup-envtest@latest use --print=overview 1.34.x
Version: 1.34.0 👈
OS/Arch: linux/arm64

The prior released version works correctly:

$ go run sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.22 use --print=overview 1.34.x
Version: 1.34.1 👈
OS/Arch: linux/arm64

Tests are also failing:

$ (cd ./tools/setup-envtest && go run github.com/onsi/ginkgo/v2/ginkgo -r --succinct)
[1762277146] Env Suite - 7/7 specs ••••••• SUCCESS! 535µs PASS
[1762277146] Store Suite - 15/15 specs ••
------------------------------
• [FAILED] [0.000 seconds]
Store listing items [It] should filter results by the given filter, sorted in version order (newest first)
controller-runtime/tools/setup-envtest/store/store_test.go:63
…
------------------------------
••••••••••••

Summarizing 1 Failure:
  [FAIL] Store listing items [It] should filter results by the given filter, sorted in version order (newest first)
  /home/cbandy/code/controller-runtime/tools/setup-envtest/store/store_test.go:69

Ran 15 of 15 Specs in 0.008 seconds
FAIL! -- 14 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestStore (0.01s)
FAIL

Ginkgo ran 5 suites in 902.063876ms

There were failures detected in the following suites:
  store ./store

Test Suite Failed

I suspect the order inadvertently changed in 0ddbc52.

[sbueringer]

I would have expected that unit tests catch this, but maybe they are not covering .x

[cbandy]

I would have expected that unit tests catch this, but maybe they are not covering .x

Is there a PR check that runs tests?

[cbandy]

When no versions are available locally, it selects the oldest version available remotely:

$ go run sigs.k8s.io/controller-runtime/tools/setup-envtest@latest cleanup
$ go run sigs.k8s.io/controller-runtime/tools/setup-envtest@latest use --print=overview
Version: 1.23.5
OS/Arch: linux/arm64

[sbueringer]

Is there a PR check that runs tests?

Yes!