Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with upgrade to Ginkogo v2 for printer function #2884

Closed
snidama2 opened this issue Jul 23, 2024 · 3 comments
Closed

Issue with upgrade to Ginkogo v2 for printer function #2884

snidama2 opened this issue Jul 23, 2024 · 3 comments
Labels
kind/support Categorizes issue or PR as a support question.

Comments

@snidama2
Copy link

With the new upgrade to controller-runtime, as it is using ginkgo v2 I am unsure how to edit my test suite so it can adapt to the sigs.k8s.io/controller-runtime/pkg/envtest/printer package being removed.

For instance, I have this code:
[]Reporter{printer.NewlineReporter{}})

I am trying to edit this to use the GinkgoWriter.Println() functionality, but I keep running into errors, so what is the best way to alter the code above to not use the printer package and use the ginkgo v2 functions?

@troy0820
Copy link
Member

This PR where it was removed shows how this project managed to migrate from v1 #1977

Also this documentation speaks to how to do it in the deprecated function.

https://pkg.go.dev/github.com/onsi/ginkgo/v2#RunSpecs

@troy0820
Copy link
Member

/kind support

/close

Closing, if you have any more issues with this, please reopen. @snidama2

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Aug 19, 2024
@k8s-ci-robot
Copy link
Contributor

@troy0820: Closing this issue.

In response to this:

/kind support

/close

Closing, if you have any more issues with this, please reopen. @snidama2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question.
Projects
None yet
Development

No branches or pull requests

3 participants