Undefined SwitchMetric Error with client-go 0.30.0 in Go Vet

[kkb0318]

I recently updated to client-go version 0.30.0 while developing a Kubernetes controller using the Operator SDK. When running go vet ./... on my project, the following error occurred, suggesting an issue with the controller-runtime package:

❯ go vet ./...
# sigs.k8s.io/controller-runtime/pkg/metrics
/Users/kkb/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.3/pkg/metrics/leaderelection.go:26:71: undefined: leaderelection.SwitchMetric

Go Version

go version go1.22.2 darwin/amd64

OS

MacOS 14.4.1

[sbueringer]

Controller-runtime v0.17.3 is using client-go 0.29.

Sometimes it's impossible for us to be compatible with multiple client-go versions at the same time. IIRC this is such a case.

So I think the only options are:

• to stay on client-go 0.29 (for now)
• to switch to controller-runtime main branch + client-go 0.30 (and eventually upgrade to v0.18)

[kkb0318]

Thank you for the quick response and the clarification.

I appreciate the guidance on compatible versions. I wasn't aware that client-go had updated so recently.
I will wait to update until the controller-runtime is compatible with the newer client-go version.

Thanks again for your support!

[sbueringer]

You're welcome.

The general pattern at the moment is that we have a 1:1 mapping between controller-runtime and client-go (i.e. at least 1 controller-runtime release for every client-go release)

We try to stay as compatible as possible with other client-go versions but that is not always possible. It largely depends on if there are breaking changes in client-go and what these are (i.e. if they can be mitigated).

There is now also a PR in k/k: kubernetes/kubernetes#124372. Depending on the outcome it could be that client-go v0.30.1+ will be compatible with CR v0.17 again.