Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a validation script to verify go.mod is in sync with k/k #2769

Closed
sbueringer opened this issue Apr 11, 2024 · 3 comments · Fixed by #2774
Closed

Add a validation script to verify go.mod is in sync with k/k #2769

sbueringer opened this issue Apr 11, 2024 · 3 comments · Fixed by #2774
Assignees

Comments

@sbueringer
Copy link
Member

sbueringer commented Apr 11, 2024

xref: #2765 (comment)

Idea is to verify on PRs (pre-submit) that our go.mod file doesn't go out of sync with Kubernetes (with the k/k version we use). The goal is to avoid issues like this: #2742 which can easily sneak in when we just merge dependabot PRs.

(we might want to consider exceptions for a few dependencies like ginkgo / gomega but that is TBD)

@alexandremahdhaoui
Copy link
Contributor

/assign

@alexandremahdhaoui
Copy link
Contributor

alexandremahdhaoui commented Apr 14, 2024

@sbueringer I created a small tool to verify go.mod and added it to the verify-modules make target. To proceed with enabling this verification in PRs, is it better to create a new dedicated workflow? Or add the tool to kubernetes-sigs/kubebuilder-release-tools?

@sbueringer
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants