-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnqueueRequestForOwner doesn't correctly enqueue cluster-scoped owner #228
Comments
/kind bug |
/good-first-issue |
@DirectXMan12: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'd like to work on this, with some hand-holding. How do I get started with making changes? |
looks like #274 is working on this |
I think this can be closed now that #274 is merged. Reopen if I'm wrong about that. |
@grantr: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/controller: re-add to the queue failed reconcile keys
Splitting out the cluster-scoped owner scenario from #214.
As pointed out by @liggitt, cluster-scoped owners are now explicitly supported.
EnqueueRequestForOwner
doesn't support this relationship because it uses the namespace of the owned object as the namespace of the owner. We ran into this in knative/eventing#649.The text was updated successfully, but these errors were encountered: