Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a terminal error type that doesn't get retried #2215

Closed
alvaroaleman opened this issue Feb 28, 2023 · 2 comments · Fixed by #2325
Closed

Consider adding a terminal error type that doesn't get retried #2215

alvaroaleman opened this issue Feb 28, 2023 · 2 comments · Fixed by #2325
Assignees

Comments

@alvaroaleman
Copy link
Member

There are various cases in which a reconciler hits an error that it knows won't get resolved with retrying. Today, the common approach for this is to not return an error at all but just log this instead.

We should consider adding such an error type because:

  • This is something that is frequently-ish needed
  • Not returning an error means that terminal errors don't appear in metrics or the logs controller-runtime emits
@sbueringer
Copy link
Member

Sounds reasonable to me

@TomNeyland
Copy link

There is some relevant discussion in #617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants