-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.14.1 regression: cannot use server-side apply #2125
Comments
Fixes in the latest 0.14.3 release. |
Unfortunately the fix seems incomplete. ForceOwnership is still missing the ApplyToSubResourcePatch method. |
@Gchbg please feel free to submit a fix |
justinsb
added a commit
to justinsb/controller-runtime
that referenced
this issue
Mar 31, 2023
Ensure that we can force when applying to subresources (in particular status) Issue kubernetes-sigs#2125
justinsb
added a commit
to justinsb/controller-runtime
that referenced
this issue
Mar 31, 2023
Ensure that we can force when applying to subresources (in particular status) Issue kubernetes-sigs#2125
k8s-infra-cherrypick-robot
pushed a commit
to k8s-infra-cherrypick-robot/controller-runtime
that referenced
this issue
Mar 31, 2023
Ensure that we can force when applying to subresources (in particular status) Issue kubernetes-sigs#2125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
After upgrading from 0.13.1 to 0.14.1, I can no longer use server-side apply.
In 0.13.1 I used to be able to do this:
err = r.Status().Patch(ctx, obj, client.Apply, client.FieldOwner("whatever"), client.ForceOwnership)
In 0.14.1 this results in:
I assume this is due to the breaking change introduced in #2072. It seems that client.FieldOwner and client.ForceOwnership were not updated to use the new SubResourcePatchOption interface instead of the existing PatchOption interface.
If this was intended, I would appreciate any insight about what the line of code should look like in 0.14.1.
Thanks!
The text was updated successfully, but these errors were encountered: