Skip to content

support configuring RecoverPanic globally #2001

Closed
@mars1024

Description

@mars1024

Now RecoverPanic is only a field in controller.Options, if we want to enable this for all controllers, each controller initialization should be modified.

Since GroupKindConcurrency and CacheSyncTimeout can both be set through global v1alpha1.ControllerConfigurationSpec, IMO, RecoverPanic can do the same.

The only left problem is that RecoverPanic is bool type which has no zero-value, so maybe it has to be changed to pointer type, but i'm afraid this will be a break change.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions