Skip to content

redundant manager.Options fields #1936

Closed
@mythi

Description

@mythi

The topic was originally raised in #1897 (comment)

With more functionality being added to webhook.Server, I think users should move to use that and also pay attention to things like TLS settings. With that, these manager.Options seem redundant:

        // Port is the port that the webhook server serves at.
	// It is used to set webhook.Server.Port if WebhookServer is not set.
	Port [int](https://pkg.go.dev/builtin#int)
	// Host is the hostname that the webhook server binds to.
	// It is used to set webhook.Server.Host if WebhookServer is not set.
	Host [string](https://pkg.go.dev/builtin#string)

	// CertDir is the directory that contains the server key and certificate.
	// If not set, webhook server would look up the server key and certificate in
	// {TempDir}/k8s-webhook-server/serving-certs. The server key and certificate
	// must be named tls.key and tls.crt, respectively.
	// It is used to set webhook.Server.CertDir if WebhookServer is not set.
	CertDir [string](https://pkg.go.dev/builtin#string)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions