Panic in fake client

[jsafrane]

I tried to write unit tests using the fake client and List() panics reliably when accessing opts.Raw:

controller-runtime/pkg/client/fake/client.go

Lines 80 to 82 in ddf0390

	func (c *fakeClient) List(ctx context.Context, opts *client.ListOptions, list runtime.Object) error {
	gvk := opts.Raw.TypeMeta.GroupVersionKind()
	gvr, _ := meta.UnsafeGuessKindToResource(gvk)

Why opts.Raw must be filled (it's not necessary when using the real client) and why it's TypeMeta should have any value?

If I understand the code (and I probably don't), it expects opts.Raw.TypeMeta.GroupVersionKind() to be the kind of items in returned list, not the list itself (i.e. Pod instead of PodList). Such requirement looks very odd.

[DirectXMan12]

/kind bug

I think this is just straight-up a bug. I seem to recall discussion a solution at some point, but can't recall what it was.

[sverrirsig]

Is anybody looking into this bug? :)

[skeggi]

Any intent to fix?

[DirectXMan12]

I don't think anyone's working on it right now. If you want to, please let me know. Like most bugs, we do intend to fix it eventually -- we're just all fairly busy :-)

/priority important-longterm

[hasbro17]

@jsafrane Is this still an issue? I think this has been fixed with #213 in the v0.1.8 release.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[DirectXMan12]

closing as per above comment