Starting event source log for Channel contains error

[shawn-hurley]

Right now I am getting this log when starting a watch on a source of type Channel

{"level":"info","ts":1537378068.766453,"logger":"kubebuilder.controller","caller":"controller/controller.go:120","msg":"Starting EventSource","Controller":"database-controller","SourceError":"json: unsupported type: <-chan event.GenericEvent"}

[DirectXMan12]

/kind bug

[DirectXMan12]

huh, I can't find where we log any field called SourceError. In pkg/internal/controller/controller.go on line 120, we have log.Info("Starting EventSource", "Controller", c.Name, "Source", src), but I'm having trouble seeing why it would log that message instead. Do you have a simple reproducer that we can play around with?

[shawn-hurley]

It is going to log that message because of

controller-runtime/pkg/source/source.go

Line 105 in d4dff20

type Channel struct {

is the source. I believe the logger is attempting to take the source struct and convert to JSON. But channels, I don't think, can be converted to JSON. does that make sense?

[DirectXMan12]

aaaah, yeah, that makes sense. Maybe we should just implement String() on all the source the source types?

[shawn-hurley]

That makes sense to me, I can take this on if you have other stuff going on?

[DirectXMan12]

yeah, that'd be great :-)