-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Deprecation of io/ioutil (in Go 1.16) #1518
Comments
I think we'll have to wait a while on this one unless we want to 100% require Go 1.16+, which seems like it's too soon to require that every operator project using controller-runtime be able to upgrade. |
#1389 |
/assign @cndoit18 |
controller-runtime is a library, so while this repo is built and tested with Go 1.16, I don't think we (yet) require that all library users use 1.16. I could be wrong though, I haven't tried building any of my operators with 1.15 lately :) If we already made the choice to use 1.16-only stuff then 100% yes we should do this. Otherwise we should probably ride the deprecation another few months at least to give people time to switch without cutting them off from new c-r releases. |
you are right. the key issue is whether we require users to use Go 1.16 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
I think we should sit on this until we stop supporting Go versions that don't have /lifecycle frozen |
Please see https://golang.org/doc/go1.16#ioutil
We have a lot of references to ioutil which we need to migrate to newer package(s) mentioned in the url above:
https://cs.k8s.io/?q=io%2Fioutil&i=nope&files=.*%5C.go&excludeFiles=&repos=kubernetes-sigs/controller-runtime
We also need some verify scripts to ensure we don't add back this package
The text was updated successfully, but these errors were encountered: